fix(scatter): 散点图刷选交互之后的 scale 处理 #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview d0de0df has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2649.surge.sh?type=diff&date=2021-06-22 🕐 Build time: 81.216s
🤖 By surge-preview |
visiky
changed the title
depends on: antvis/G2#3485
Pull Request Test Coverage Report for Build 960795950
💛 - Coveralls |
visiky
changed the title
hustcc
reviewed
Jun 29, 2021
| const maxX = max(xValues); | ||
| const yValues = data.map((d) => d[yField]); | ||
| const minY = min(yValues); | ||
| const maxY = max(yValues); |
There was a problem hiding this comment.
这里要做性能提升。其实只需要判断 isSameXValue，isSameYValue。
hustcc
reviewed
Jun 29, 2021
| meta({ chart, options }); | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
可以放到 changeData 函数中，用 this.once 更节省。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
Screenshot